Skip to content

fix(http): resolve new clippy lints#2091

Merged
7596ff merged 1 commit intotwilight-rs:mainfrom
suneettipirneni:fix/clippy-errors
Jan 28, 2023
Merged

fix(http): resolve new clippy lints#2091
7596ff merged 1 commit intotwilight-rs:mainfrom
suneettipirneni:fix/clippy-errors

Conversation

@suneettipirneni
Copy link
Copy Markdown
Member

This fixes some clippy errors that seem to have been introduced in the latest rust updates.

@github-actions github-actions bot added the c-http Affects the http crate label Jan 27, 2023
@spring4175 spring4175 changed the title chore: fix clippy errors fix(http): clippy errors Jan 27, 2023
@spring4175 spring4175 changed the title fix(http): clippy errors fix(http): resolved new clippy lints Jan 27, 2023
@github-actions github-actions bot added the t-fix Fixes a bug in the library label Jan 27, 2023
@spring4175 spring4175 changed the title fix(http): resolved new clippy lints fix(http): resolve new clippy lints Jan 27, 2023
Copy link
Copy Markdown
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one other clippy failure specifically on next, with a fix is included in #2090. I'll split that into its own separate PR that can land after this one is on next (i.e. this PR will "break" next as it does not include the next specific lint)

@7596ff 7596ff merged commit 1aa8369 into twilight-rs:main Jan 28, 2023
@suneettipirneni suneettipirneni deleted the fix/clippy-errors branch January 28, 2023 05:21
@vilgotf
Copy link
Copy Markdown
Member

vilgotf commented Jan 28, 2023

There's one other clippy failure specifically on next, with a fix is included in #2090. I'll split that into its own separate PR that can land after this one is on next (i.e. this PR will "break" next as it does not include the next specific lint)

This worked around in 9018ed8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-http Affects the http crate t-fix Fixes a bug in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants